[chore][exporter/googlecloudpubsub] improve unit testing #37347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanboxel
suggested changes
Jan 20, 2025
kevinnoel-be
force-pushed
the
pubsub-improve-tests
branch
2 times, most recently
from
682f914 to
0a380ec
Compare
alexvanboxel
approved these changes
Jan 20, 2025
fatsheep9146
approved these changes
Jan 21, 2025
fatsheep9146
added
the
ready to merge
kevinnoel-be
force-pushed
the
pubsub-improve-tests
branch
from
0a380ec to
2617fee
Compare
We have metadata now, this is not needed anymore
kevinnoel-be
force-pushed
the
pubsub-improve-tests
branch
from
2617fee to
e75a51c
Compare
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…try#37347) #### Description Improves unit testing without having to rely on an emulated server. #### Link to tracking issue Part of the preparation for open-telemetry#32850, as mentioned in open-telemetry#36591 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves unit testing without having to rely on an emulated server.
Link to tracking issue
Part of the preparation for #32850, as mentioned in #36591 (comment)