Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported ordering key in googlecloudpubsub exporter #32850

Open
brandonbirdj opened this issue May 3, 2024 · 11 comments · May be fixed by #37587
Open

Supported ordering key in googlecloudpubsub exporter #32850

brandonbirdj opened this issue May 3, 2024 · 11 comments · May be fixed by #37587
Assignees
@alexvanboxel
Labels
enhancement New feature or request exporter/googlecloudpubsub

Comments

@brandonbirdj
Copy link

Component(s)

exporter/googlecloudpubsub

Is your feature request related to a problem? Please describe.

Allow for ordered messages to be published to pubsub

Describe the solution you'd like

Add new support for field ordering key in exporter

Ordering keys can be used like this in pubsub. I propose we configure an attribute to contain the key used for the exporter.

Messages: []*pubsubpb.PubsubMessage{
			{
				Attributes: attributes,
				Data:       data,
				OrderingKey: attributes["OrderingKey"],
			},
		},

The name of the attribute would be configured in the exporter like so.

exporters:
  googlecloudpubsub:
    project: abc
    endpoint: mytestendpoint
    user_agent: projects/abc/topics/requests
    ordering_key_attribute: OderingKey

Describe alternatives you've considered

na

Additional context

https://cloud.google.com/pubsub/docs/ordering

https://medium.com/google-cloud/google-cloud-pub-sub-ordered-delivery-1e4181f60bc8
@brandonbirdj brandonbirdj added enhancement New feature or request needs triage New item requiring triage labels May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@alexvanboxel
Copy link
Contributor

alexvanboxel commented May 4, 2024 •
edited
Loading

Funny, it was already on my planned short list; this can be assigned to me.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 8, 2024
@alexvanboxel
Copy link
Contributor

still planned, don't close

@github-actions github-actions bot removed the Stale label Jul 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
@alexvanboxel
Copy link
Contributor

@open-telemetry/collector-contrib-triagers this issue can be re-opened as this is actively being worked on by @kevinnoel-be

@VihasMakwana VihasMakwana reopened this Nov 28, 2024
@VihasMakwana
Copy link
Contributor

@alexvanboxel should I assign this to @kevinnoel-be ?

@alexvanboxel
Copy link
Contributor

@alexvanboxel should I assign this to @kevinnoel-be ?

Doesn't matter, we're colleagues and I will need to follow up as code-owners anyway. Whatever you prefer.

@alexvanboxel alexvanboxel mentioned this issue Nov 29, 2024
Merged
@kevinnoel-be kevinnoel-be mentioned this issue Jan 20, 2025
Merged
songy23 pushed a commit that referenced this issue Jan 21, 2025
@kevinnoel-be
[chore][exporter/googlecloudpubsub] improve unit testing (#37347)
a7e3857 
#### Description
Improves unit testing without having to rely on an emulated server.

#### Link to tracking issue
Part of the preparation for #32850, as mentioned in
#36591 (comment)
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@kevinnoel-be @chengchuanpeng
[chore][exporter/googlecloudpubsub] improve unit testing (open-teleme…
c4e8f2a 
…try#37347)

#### Description
Improves unit testing without having to rely on an emulated server.

#### Link to tracking issue
Part of the preparation for open-telemetry#32850, as mentioned in
open-telemetry#36591 (comment)
@alexvanboxel alexvanboxel mentioned this issue Jan 27, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 29, 2025
@alexvanboxel
Copy link
Contributor

alexvanboxel commented Jan 29, 2025 •
edited
Loading

not stale, implementation almost ready

@crobert-1 crobert-1 removed the Stale label Jan 29, 2025
@kevinnoel-be kevinnoel-be linked a pull request Jan 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexvanboxel alexvanboxel

Labels
enhancement New feature or request exporter/googlecloudpubsub
Projects
None yet
Milestone
No milestone
4 participants
@alexvanboxel @brandonbirdj @crobert-1 @VihasMakwana