-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/long-term scheduler #20
Conversation
@L-M-Sherlock I have refactored the code to make it more in line with Go's philosophy. Notable Points:
And some points related to end-user:
|
Backward un-compatible:
@L-M-Sherlock Should we do more to make it compatible with v2 (since its launch is so close)? |
I hope it's more consistent with ts-fsrs interface. |
For the first one, It's likely possible to just add a deprecated Anyway, we can definitely just release a v3 version. 😂 |
OK, let's release the v3 version. But I also plan to implement the fuzz feature. If we implement it, should we release v4? |
For golang, we should release a new major version if and only if we do something not back-compatible. So, if the fuzz feature requests the user to change their existing code, we should release v4. And if not, we should keep using v3. |
Thanks for the clarification about the versioning of golang module. Fuzz only requires to add a new variable to the Parameters structure. I think it's back-compatible? |
It depends. I think for most cases people will use But there's another case if the user deserializes the Parameters from DB, and in this scenario, the newly introduced variable will become the zero value in golang. So this may be back-incompatible. However, if the newly introduced variable is only used in the fuzz feature, it would still be considered backward-compatible. So in fact, this is still a case-by-case scenario, and we can discuss it further if the feature is available. |
OK. Let's update the go.mod file to upgrade the version, and delay the discussion about v4 to the next PR. I will implement the fuzz feature when I come back from vacation. |
@ImSingee I translated most code from ts-fsrs, so the code style seems weird to Golang. Could you help me improve it? I have added the unit test.