Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/option enable_short_term in training #258

Merged
merged 7 commits into from
Jan 1, 2025

Conversation

L-M-Sherlock
Copy link
Member

close #255

The API is changed in this PR, but I don't want to release a version because #256 also requires a major change.

What's the best practice for this case?

@asukaminato0721
Copy link
Collaborator

asukaminato0721 commented Dec 16, 2024

in py, we use something like default parm so the api doesn't break.

def f(val = true)
f()

but since rust doesn't have it

one way is to separate the method

fn f( val: bool )

to

fn f() // by default true
fn f_false()

so the api doesn't break.

btw it's usually called partial function

@L-M-Sherlock
Copy link
Member Author

@asukaminato0721 cc f0f2542

@asukaminato0721
Copy link
Collaborator

And if you do want to merge these api. Add https://stackoverflow.com/questions/30757914/can-i-mark-a-function-as-deprecated to them and let users to use new api :)

@L-M-Sherlock
Copy link
Member Author

@dae, I find it's really hard to solve the problems mentioned in open-spaced-repetition/fsrs4anki#708, so I decided to provide an option to freeze the stability in FSRS-5 if the user has trouble with the same-day reviews. What do you think of?

@L-M-Sherlock
Copy link
Member Author

Because #267 will introduce a breaking change, I decide not to use partial function.

@L-M-Sherlock L-M-Sherlock merged commit 9809beb into main Jan 1, 2025
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/option-enable_short_term-in-training- branch January 1, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] Option to disable stability_short_term
2 participants