Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/option enable_short_term in training #151

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Feat/option enable_short_term in training #151

merged 2 commits into from
Dec 17, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Dec 16, 2024 •
edited
Loading

same to open-spaced-repetition/fsrs-rs#258

benchmark results:

Weighted by number of reviews

Model #Params LogLoss RMSE(bins) AUC
FSRS-5 19 0.328±0.0081 0.052±0.0015 0.701±0.0044
FSRS-5-disable_short_term 17 0.331±0.0082 0.053±0.0016 0.694±0.0042
FSRS-4.5 17 0.332±0.0082 0.054±0.0016 0.692±0.0041

Weighted by number of users

Model #Params LogLoss RMSE(bins) AUC
FSRS-5 19 0.357±0.0045 0.074±0.0012 0.699±0.0024
FSRS-5-disable_short_term 17 0.361±0.0045 0.076±0.0013 0.690±0.0023
FSRS-4.5 17 0.362±0.0045 0.076±0.0013 0.689±0.0023

@L-M-Sherlock L-M-Sherlock marked this pull request as ready for review December 17, 2024 04:35
@L-M-Sherlock L-M-Sherlock added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 58f98a8 Dec 17, 2024
4 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/option-enable_short_term-in-training branch December 17, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@L-M-Sherlock