Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @nhim-uit as a contributor #563

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Conversation

nhim-uit
Copy link
Contributor

@nhim-uit nhim-uit commented Nov 5, 2024

Description

This PR adds @nhim-uit as a contributor.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #557

Contributors Checklist

I've read through the Getting Started section

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

contributor

[optional] What GIF best describes this PR or how it makes you feel?

@nhim-uit nhim-uit requested a review from a team as a code owner November 5, 2024 03:42
Copy link

github-actions bot commented Nov 5, 2024

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @nhim-uit! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@nhim-uit nhim-uit changed the title docs: add @nhim-uit as a contributor feat: add @nhim-uit as a contributor Nov 5, 2024
@nhim-uit nhim-uit changed the title feat: add @nhim-uit as a contributor feat: Add @nhim-uit as a contributor Nov 5, 2024
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nhim-uit,
Thank you for your contribution! ✨

We have merged a PR before yours. Please resolve the conflicts before we can review your PR.

Let me know if you have questions or need any help. Thanks. 😊

@nhim-uit
Copy link
Contributor Author

Hey @nhim-uit, Thank you for your contribution! ✨

We have merged a PR before yours. Please resolve the conflicts before we can review your PR.

Let me know if you have questions or need any help. Thanks. 😊

Hi, I've resolved the conflicts and move my info to the bottom of the file.
Please have a look. 😊

@adiati98
Copy link
Member

@nhim-uit, have you run the command to generate the README? Because I don't see the badge increasing.

@nhim-uit
Copy link
Contributor Author

@nhim-uit, have you run the command to generate the README? Because I don't see the badge increasing.

Hi, I've run the command. Please check 😊

@adiati98 adiati98 merged commit aa8a93f into open-sauced:main Nov 11, 2024
3 checks passed
@adiati98
Copy link
Member

Well done and thank you for your contribution, @nhim-uit! ✨

If you haven't, you can join our Community.
Also, check out our pizza-verse repo if you want to contribute further! 🍕🍴

git merge GIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @nhim-uit as a contributor
3 participants