Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @asirialwis as a contributor #550

Closed
wants to merge 1 commit into from

Conversation

asirialwis
Copy link
Contributor

Description

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Contributors Checklist

I've read through the Getting Started section

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

[optional] What GIF best describes this PR or how it makes you feel?

@asirialwis asirialwis requested a review from a team as a code owner October 31, 2024 15:08
Copy link

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @asirialwis! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

@adiati98
Copy link
Member

adiati98 commented Oct 31, 2024

Hey @asirialwis ,
We appreciate your contribution. ✨

However, we will close this PR with the following reasons:

  • You made changes right in the main branch, which we don't allow.
  • There is no issue accompanying your PR.

That being said, if you'd still like to contribute, please:

  • Create an issue to add yourself to the guestbook.
  • Create a new branch from the latest updated mainbranch to work on your changes.
  • Create a new PR and complete the PR template.

Thank you.

@adiati98 adiati98 closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants