Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add information to write PR details outside the comments #524

Closed
wants to merge 1 commit into from
Closed

docs: Add information to write PR details outside the comments #524

wants to merge 1 commit into from

Conversation

Brijeshthummar02
Copy link
Contributor

@Brijeshthummar02 Brijeshthummar02 commented Oct 12, 2024 •
edited
Loading

Fixes #521

@Brijeshthummar02 Brijeshthummar02 requested a review from a team as a code owner October 12, 2024 16:37
github-actions[bot]
github-actions bot reviewed Oct 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Brijeshthummar02 Brijeshthummar02 changed the title Docs: Add information to write PR details outside the comments docs: Add information to write PR details outside the comments Oct 12, 2024
adiati98
adiati98 requested changes Oct 13, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Brijeshthummar02,

I've assigned the issue to you. However, for your future reference, please don't work on any changes and create a PR before you get assigned. 👍🏼

Also, you may not delete any section in the PR template even though they're not relevant to your PR.
You need to read the comments in the PR template carefully. Two of them says:

<!-- Please fill in all areas in this PR form. Incomplete PRs will be marked invalid and may be closed. -->
<!-- note: PRs with deleted sections will be marked invalid -->

That said, please fix your PR template before we review it. You may leave the sections that are not related to your changes blank. Alternatively, you can close this PR and create a new PR.

Thank you. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adiati98 adiati98 adiati98 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add information to write PR details
2 participants
@Brijeshthummar02 @adiati98