Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unknown contribution type error when running npm run contributors:add locally #156

Merged

Conversation

jdwilkin4
Copy link
Contributor

Description

This PR fixes the bug for the following error message:

Error: Unknown contribution type web development for contributor

Screenshot 2023-10-25 at 12 06 59 PM

I updated the contributors array for where the invalid value was.
I tested this by running the npm run contributors:add command locally to add my name and the error is no longer there as evidence by this screenshot
Screenshot 2023-10-25 at 1 56 36 PM

this also fixes same error that was showing when you ran the npm run contributors:generate command locally.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

closes #155

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@CBID2 CBID2 enabled auto-merge October 25, 2023 21:02
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 merged commit d2e9386 into open-sauced:main Oct 25, 2023
1 check passed
@adiati98
Copy link
Member

Thanks, @jdwilkin4! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unknown contribution type error when trying to run the npm run contributors:add command
3 participants