Bug: Unknown contribution type error when trying to run the npm run contributors:add command

[jdwilkin4]

Describe the bug

I tried running the npm run contributors:add command locally, and ran into this error

Error: Unknown contribution type web development for contributor

Here is the complete screenshot

The error is happening because web development is not a valid entry for the contributions array

 "contributions": [
        "web development"
      ]

the fix would be to change that to code since that is a valid entry

 "contributions": [
        "code"
      ]

But also, for the long term it might be nice to have an additional check in place to double check that the contributions array only holds valid values.
That way if a user tries to contribute to the guestbook manually with an invalid value, then the check will catch that.

Steps to reproduce

1. got the guestbook repo locally
2. pull down the latest changes from main
3. create a new branch
4. run the npm run contributors:add command
5. see the error

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[jdwilkin4]

it looks like this error also affects the generate command to

[CBID2]

Hey @jdwilkin4. Have you checked this locally?

[jdwilkin4]

yes, I have included screenshots in the post above 👍

[jdwilkin4]

Here is the PR that triggered it

#153

Here is the line that needs to be changed
https://github.com/open-sauced/guestbook/blob/main/.all-contributorsrc#L1110

[adiati98]

Hey @jdwilkin4,
Thank you for spotting the bug!

I've tried it locally, and yes. It seems that this was a manual entry. And "web development" is not included in the list of emoji key and contribution type.

The solution is precisely what you described, by replacing the "web development" with "code".

And thanks for the suggestion to have the additional check. We will take that into account. :)

Do you want to work on this issue?

[jdwilkin4]

@adiati98

Sure, I can create a PR for that fix 👍

[adiati98]

Awesome! Thank you, @jdwilkin4!

[BekahHW]

Thanks, @jdwilkin4!