Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle notification examples #934

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented Oct 3, 2024

Currently parseOpenRPCDocument fails on notification examples (without result). this PR is a fix for it.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (b1a793c) to head (ae110e0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #934   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          13       13           
  Lines         335      336    +1     
  Branches       84       85    +1     
=======================================
+ Hits          334      335    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shanejonas shanejonas merged commit 1c1ad70 into master Oct 3, 2024
4 checks passed
@shanejonas shanejonas deleted the fix/handle-notification-examples branch October 3, 2024 14:32
@BelfordZ
Copy link
Member

BelfordZ commented Oct 3, 2024

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants