Docs/fix validate open rpc document example #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 2, 2023 23:22
Adjusted example code with import and try/catch BREAKING CHANGE: N
Removed try catch in favour of result because it doesn't throw an error BREAKING CHANGE: N
BREAKING CHANGE: N
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 322 322
Branches 74 74
=========================================
Hits 322 322 ☔ View full report in Codecov by Sentry. |
|
sorry it took so long to look at this, but thanks LGTM! |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@BelfordZ All good. I figured there is a lot going on. PS: Next time I'm in Van, let me know if you'd be down to meet up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Proposed solution updates example code with small fixes for imports and adjusted output to handle error a bit clearer.
Working Example:
https://replit.com/@codingwithmanny/open-rpc-validateOpenRPCDocument?v=1#index.ts