Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed robots label position. #1038

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

yutaroha
Copy link
Contributor

What's new

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Hello,
In the RMF Web Map, the robot labels appear in the top-left corner of the screen.
robots_labels

I have fixed this by changing the position of the labels. Could you please merge this fix?
robots_labels_fixed

Thank you.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug!
Could you look into signing off your commit for DCO to pass? https://github.com/apps/dco
you will need to re-sign your existing commit and force push

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (4c56455) to head (447fe91).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...framework/src/components/map/robot-three-maker.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   40.74%   40.60%   -0.14%     
==========================================
  Files         334      334              
  Lines       17211    17211              
  Branches      682      680       -2     
==========================================
- Hits         7013     6989      -24     
- Misses      10094    10118      +24     
  Partials      104      104              
Flag Coverage Δ
rmf-dashboard-framework 32.11% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutaroha
Copy link
Contributor Author

I'm sorry.
I have performed the sign-off and pushed the changes.
Thank you.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@aaronchongth aaronchongth merged commit 6e62967 into open-rmf:main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants