Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting the validation step when a patrol task form is rendered #1013

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Reverting the validation step when a patrol task form is rendered #1013

merged 2 commits into from
Sep 27, 2024

Conversation

aaronchongth
Copy link
Member

What's new

Fixes #1012

Will look into increasing test coverage for these situations after #1007

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Lint
7f95f2b 
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth merged commit 03d747d into main Sep 27, 2024
3 checks passed
@aaronchongth aaronchongth deleted the fix/fav-patrol-trigger-validate branch September 27, 2024 09:10
@aaronchongth aaronchongth mentioned this pull request Sep 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Dashboard occasionally does not load. Favorite Tasks broken
2 participants
@aaronchongth @koonpeng