Pin iced version to fix CI #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
mxgrey
approved these changes
Oct 5, 2023
|
I plan on migrating all the visualization over to bevy once we have the right infrastructure set up on the bevy side, so all our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
This crate has been failing to compile for some time since it pointed to specific git versions, from a fork, of the
icedcrate but pointed to upstream main for a related crateiced_aw, which is a moving target and eventually became incompatible.Fix applied
Pin the
iced_awdependency to the 0.1.0 version which is the one that depends on iced 0.3.0 on the pointed forks.I haven't looked into whether it is possible to migrate out of the fork but it seems the upstream library changed quite dramatically so it might not be too simple.