Enh: Make RecordDifference more robust #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where record parameters are malformed, they may not load correctly as a dict, and then `rec.parameters.pop` raises AttributeError. One may still want to compare the record to another however – for example, to identify differences with a record where parameters are not malformed. Adding a `hasattr` guard helps with this corner case, and as far as I can tell has no downsides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a corner case in
records.py::RecordDifference.In cases where record parameters are malformed, they may not load correctly as a dict, and then
rec.parameters.popraisesAttributeError. One may still want to compare the record to another however – for example, to identify differences with a record where parameters are not malformed. Adding ahasattrguard helps with this corner case, and as far as I can tell has no downsides.