Convert elements of sys.argv to type newstr to work around a bug in python-future #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for a bug in python-future which makes the test
isinstance(..., str)
fail when applied to strings read from the command line viasys.argv
. This bug has caused me problems on Python 2.7 when reading parameters from the command line. The attached PR fixes this.However, we should only consider this a temporary solution. Once the bug is fixed upstream in
python-future
we should revert this change.