-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DTLS 1.3 support #586
Add DTLS 1.3 support #586
Conversation
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
Signed-off-by: Michael Baentsch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, LGTM.
@praveksharma fyi, this was the last PR blocking the 0.8.0 release that you volunteered doing. Please note that #545 has not been resolved so a manual test is still needed: Please let me know if you'll do it or whether I should do that. A failure impacts OpenSSL CI if/when the release gets integrated there. |
As per openssl/openssl#13900 (comment), this PR adds version-conditional (also testing) support for DTLS1.3. This has been manually successfully tested against openssl feature/dtls-1.3 branch. CI will automatically run DTLS test cases as and when DTLS1.3 lands for good in OpenSSL.