Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds note on supported openssl versions for tls certificates. #498

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Aug 25, 2024

Fixes #492

@fwh-dc fwh-dc requested a review from baentsch as a code owner August 25, 2024 19:13
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation improvement, @fwh-dc !

Two nits: 1) Would you agree that underlying the whole new text with a link to https://github.com/open-quantum-safe/oqs-provider#note-on-openssl-versions would give additional context? If so, please amend the PR suitably. 2) Could you please add the tag "[skip ci]" to (any future) commits changing only documentation? The environment says Thanks (saving many CI compute cycles)

@fwh-dc
Copy link
Contributor Author

fwh-dc commented Aug 26, 2024

Good point. How should I add the tag? In the commit message?

@baentsch
Copy link
Member

Good point. How should I add the tag? In the commit message?

Yes. Simply add "[skip ci]" at the end of the commit message (without the additional "" of course).

@baentsch baentsch merged commit c9b8056 into open-quantum-safe:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use dilithium certificates with s_server
2 participants