Fix #372: expose `hybrid_classical_` and `hybrid_pq_` `OSSL_PARAMS` for `EVP_PKEY`. #374

ghost · 2024-03-14T13:49:36Z

Fix #372: expose hybrid_classical_ and hybrid_pq_ OSSL_PARAMS for EVP_PKEY.

This commit is an attempt to fix #372, by adding four new OSSL_PARAM to
EVP_PKEY.

The following OSSL_PARAM are added by this commit:

hybrid_classical_pub: an octet string to the classical public key.
hybrid_classical_priv: an octet string to the classical private key.
hybrid_pq_pub: an octet string to the quantum-resistant public key.
hybrid_pq_priv: an octet string to the quantum-resistant private key.

Using EVP_PKEY_get_params, OpenSSL users should be able to extract the
specific subkey they want from an hybrid key.

A test called test_evp_pkey_params has been added to ensure that it works
with all hybrid algorithms, to also ensure that the output of these parameters
are consistent between each other.

Signed-off-by: thb-sb [email protected]

Ericyu0412

Thank you very much for adding this feature, which will help promote the promotion of hybrid digital signature certificates.

oqsprov/oqs_kmgmt.c

test/oqs_test_evp_pkey_params.c

baentsch

Technically, looks like a good solution for #372, thanks @thb-sb ! Beyond the single PR comments regarding (algorithm-mutation) automation as well as constants-naming and -location this currently is an undocumented/"hidden feature": What about adding a section on "Supported parameters" to USAGE.md, documenting at least these 4 new params, possibly also all (other) retrievable OSSL_ params pointing to their documentations, e.g. OSSL_SIGNATURE_PARAM_DIGEST?

ghost · 2024-03-15T14:26:43Z

Technically, looks like a good solution for #372, thanks @thb-sb ! Beyond the single PR comments regarding (algorithm-mutation) automation as well as constants-naming and -location this currently is an undocumented/"hidden feature": What about adding a section on "Supported parameters" to USAGE.md, documenting at least these 4 new params, possibly also all (other) retrievable OSSL_ params pointing to their documentations, e.g. OSSL_SIGNATURE_PARAM_DIGEST?

I've added a section to USAGE.md!
Let me know if it's OK for you.

oqsprov/oqs_sig.c

oqsprov/oqsprov_keys.c

baentsch

Does the new test keep working if new hybrids or new algs are introduced? I'm not sure. Other question: Any chance the test output could be red/green coded like all other ctest runs?

ghost · 2024-03-18T17:55:48Z

Does the new test keep working if new hybrids or new algs are introduced? I'm not sure

It should be working now with the jinja2 template I added in 8b278d4.

Other question: Any chance the test output could be red/green coded like all other ctest runs?

Yes :) done in 8b278d4 also

…or `EVP_PKEY`. This commit is an attempt to fix #372, by adding four new [`OSSL_PARAM`] to [`EVP_PKEY`]. The following [`OSSL_PARAM`] are added by this commit: - `hybrid_classical_pub`: an octet string to the classical public key. - `hybrid_classical_priv`: an octet string to the classical private key. - `hybrid_pq_pub`: an octet string to the quantum-resistant public key. - `hybrid_pq_priv`: an octet string to the quantum-resistant private key. Using [`EVP_PKEY_get_params`], OpenSSL users should be able to extract the specific subkey they want from an hybrid key. A test called `test_evp_pkey_params` has been added to ensure that it works with all hybrid algorithms, to also ensure that the output of these parameters are consistent between each other. [`OSSL_PARAM`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PARAM.html [`EVP_PKEY`]: https://www.openssl.org/docs/man3.2/man7/evp.html [`EVP_PKEY_get_params`]: https://www.openssl.org/docs/man3.2/man3/EVP_PKEY_get_params.html Signed-off-by: thb-sb <[email protected]>

ghost force-pushed the pr374 branch 7 times, most recently from e97f2d4 to a6eda7f Compare March 14, 2024 14:30

ghost marked this pull request as ready for review March 14, 2024 18:15

ghost requested a review from baentsch as a code owner March 14, 2024 18:15

ghost requested review from bhess and dstebila March 14, 2024 18:16

ghost self-assigned this Mar 14, 2024

ghost added the enhancement New feature or request label Mar 14, 2024

Ericyu0412 reviewed Mar 15, 2024

View reviewed changes