-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not duplicate call to getenv
.
#369
Conversation
|
Was temporary: Re-run turned CI green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks, @thb-sb.
Tagging @feventura asking whether you're OK that we merge this before you rebase and squash #317 -- or whether you prefer this to be done the other way around.
I think it would be easier to wait for 317 to be merged. |
I agree, I also think it would be easier to wait for 317 to be merged. |
c3e61c1
to
5398765
Compare
As described here: #317 (comment) we shouldn't call `getenv` twice. This commit uses a `envval` variable to store the value of `getenv`. Signed-off-by: thb-sb <[email protected]>
@baentsch good to merge? I've just rebased it onto main. |
Just merged. Thanks for the improvement, @thb-sb ! |
Do not duplicate call to
getenv
.As described here: #317 (comment)
we shouldn't call
getenv
twice.This commit uses a
envval
variable to store the value ofgetenv
.Signed-off-by: thb-sb [email protected]