length and null checks in en/decaps #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
reviewed
Mar 4, 2024
baentsch
reviewed
Mar 4, 2024
baentsch
approved these changes
Mar 4, 2024
|
Thanks @baentsch, nice catch! |
On my own sloppy code :-/ Thanks for the addition. |
|
Thanks again for the contribution. Merged. |
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 13, 2024
* length and null checks in en/decaps Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
* length and null checks in en/decaps Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* length and null checks in en/decaps Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* length and null checks in en/decaps Signed-off-by: Felipe Ventura <[email protected]>
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 17, 2024
* length and null checks in en/decaps Signed-off-by: Felipe Ventura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions oqs_qs_kem_encaps_keyslot and oqs_qs_kem_decaps_keyslot are provided some buffers for the input and output parameters, with pointers to return the intended length of these buffers in case they are queried, or they hold the actual length of the provided buffers when it's not a query. These lengths are not passed on and they are not checked against the kem context. This could lead to over-writes or over-reads. Null pointers are also not handled properly.