-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a example of how to load oqsprovider using OSSL_PROVIDER_add_builtin
.
#308
Conversation
…ltin`. (See [this discussion](#307).) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html
a014f74
to
62b87a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this all together! Basically LGTM. Just wondering whether this would be a good opportunity to add a CI job running a test with "OQS_PROVIDER_STATIC=ON" (?)
Agreed! We already have one, but it runs on CircleCI, and I guess you want one that runs on github actions… Let me work on this :) |
Sincere apologies: I indeed didn't check there. No need to do this then until we tackle #248. |
…ltin`. (open-quantum-safe#308) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html Signed-off-by: Felipe Ventura <[email protected]>
…ltin`. (open-quantum-safe#308) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html Signed-off-by: Felipe Ventura <[email protected]>
…ltin`. (open-quantum-safe#308) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html Signed-off-by: Felipe Ventura <[email protected]>
…ltin`. (open-quantum-safe#308) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html Signed-off-by: Felipe Ventura <[email protected]>
…ltin`. (open-quantum-safe#308) This commit adds an example under the `examples/` directory of how to load oqsprovider using [`OSSL_PROVIDER_add_builtin`]. A CMake test target has been added to ensure that the example works. Note that this target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled. [`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html Signed-off-by: Felipe Ventura <[email protected]>
(See this discussion.)
This commit adds an example under the
examples/
directory of how to load oqsprovider usingOSSL_PROVIDER_add_builtin
.A CMake test target has been added to ensure that the example works. Note that this target is skipped if
OQS_PROVIDER_BUILD_STATIC
is not enabled.