Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a example of how to load oqsprovider using OSSL_PROVIDER_add_builtin. #308

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2023

(See this discussion.)

This commit adds an example under the examples/ directory of how to load oqsprovider using OSSL_PROVIDER_add_builtin.

A CMake test target has been added to ensure that the example works. Note that this target is skipped if OQS_PROVIDER_BUILD_STATIC is not enabled.

@ghost ghost requested a review from baentsch as a code owner December 5, 2023 12:01
…ltin`.

(See [this discussion](#307).)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html
@ghost ghost force-pushed the example_static_load branch from a014f74 to 62b87a0 Compare December 5, 2023 12:02
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this all together! Basically LGTM. Just wondering whether this would be a good opportunity to add a CI job running a test with "OQS_PROVIDER_STATIC=ON" (?)

@ghost
Copy link
Author

ghost commented Dec 5, 2023

Thanks for putting this all together! Basically LGTM. Just wondering whether this would be a good opportunity to add a CI job running a test with "OQS_PROVIDER_STATIC=ON" (?)

Agreed! We already have one, but it runs on CircleCI, and I guess you want one that runs on github actions…

Let me work on this :)

@baentsch
Copy link
Member

baentsch commented Dec 5, 2023

We already have one

Sincere apologies: I indeed didn't check there. No need to do this then until we tackle #248.

@baentsch baentsch merged commit 70856b8 into open-quantum-safe:main Dec 6, 2023
22 checks passed
@ghost ghost deleted the example_static_load branch December 6, 2023 07:46
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
…ltin`. (open-quantum-safe#308)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
…ltin`. (open-quantum-safe#308)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
…ltin`. (open-quantum-safe#308)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
…ltin`. (open-quantum-safe#308)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html

Signed-off-by: Felipe Ventura <[email protected]>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
…ltin`. (open-quantum-safe#308)

This commit adds an example under the `examples/` directory of how to load
oqsprovider using [`OSSL_PROVIDER_add_builtin`].

A CMake test target has been added to ensure that the example works. Note that this
target is skipped if `OQS_PROVIDER_BUILD_STATIC` is not enabled.

[`OSSL_PROVIDER_add_builtin`]: https://www.openssl.org/docs/man3.2/man3/OSSL_PROVIDER_add_builtin.html

Signed-off-by: Felipe Ventura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant