-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify liboqs_DIR naming convention #292
Conversation
As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase.
I'm wondering if mentioning the fact that we're using |
That's a good idea, what if I used this sentence instead: This uses the |
Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. In future PRs, please tag documentation-only changes with "[skip ci]" to avoid running pointless testing. The environment says Thanks.
good to know, many projects don't have that feature |
Yup, many IT projects don't care about their environmental impact. There's a reason data centers need about 200 TWh per year, i.e., as much as Israel, Switzerland and Finland together generate... OK, badly programmed AI probably is the biggest culprit, but just pointing to others is a cop out. |
* Clarify liboqs_DIR naming convention As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase. * added link to cmake command doc Signed-off-by: Felipe Ventura <[email protected]>
* Clarify liboqs_DIR naming convention As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase. * added link to cmake command doc Signed-off-by: Felipe Ventura <[email protected]>
* Clarify liboqs_DIR naming convention As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase. * added link to cmake command doc Signed-off-by: Felipe Ventura <[email protected]>
* Clarify liboqs_DIR naming convention As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase. * added link to cmake command doc Signed-off-by: Felipe Ventura <[email protected]>
* Clarify liboqs_DIR naming convention As per discussion in open-quantum-safe#277 we want to clarify why the env var `liboqs_DIR` does not follow standard naming convention by using lowercase. * added link to cmake command doc Signed-off-by: Felipe Ventura <[email protected]>
As per discussion in #277 we want to clarify why the env var
liboqs_DIR
does not follow standard naming convention by using lowercase.Fixes #277