Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the clang-format CI job from CircleCI to GitHub actions. #249

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2023

This commit contributes to fixing issue #248.

@ghost ghost requested a review from baentsch as a code owner September 6, 2023 07:32
This commit contributes to fixing issue #248.
@ghost ghost force-pushed the clang_format_gh_actions branch from 0d7d05a to 4944f18 Compare September 6, 2023 07:32
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this over to github CI. I am surprised, though, that this still contains code for CCI: Is the idea that we first merge #246 and then #249 (basically backing out #246)? Why not just amend #246 (drop CCI and use github in that)?

@ghost
Copy link
Author

ghost commented Sep 6, 2023

I just move the clang-format-based coding style checker here, I haven't touched the other jobs.

In #246 I already switched the ASan job to GitHub Actions. :)

@baentsch
Copy link
Member

baentsch commented Sep 7, 2023

Closing without merge as #246 landed.

@baentsch baentsch closed this Sep 7, 2023
@ghost
Copy link
Author

ghost commented Sep 7, 2023

Closing without merge as #246 landed.

I'm afraid there's been a misunderstanding here: this PR had nothing to do with 246 actually! It was all about moving the clang-format check from CircleCI to GitHub actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant