-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 March Chromium update [skip ci] #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By splitting Linux and Windows patch base this PR seems to make maintenance harder. But as you maintain this code, @Raytonne this should be your concern. Beyond the command regarding documentation of default groups, LGTM. Thanks for upgrading this!
This will make the build instruction more clear ;) |
Thanks for the updates. Two comments: 1) Are you able to create your PR's from within the oqs-demos repo? If so, CI should be able to run automatically. If you don't have the permissions, please let me know, I'll then manually pull them over. 2) Please run your commits with option "-s": It seems the new LinuxFoundation OQS masters have activated DCO... |
Update Chromium patch and build instructions: liboqs: 890a6aa448598a019e72b5431d8ba8e0a5dbcc85 boringssl: c0a0bb4d1243952819b983129c546f9ae1c03008 Chromium: 124.0.6339.0 Co-authored-by: pi-314159 <[email protected]> Signed-off-by: Raytonne <[email protected]>
Signed-off-by: Raytonne <[email protected]>
Signed-off-by: Raytonne <[email protected]>
|
Any further updates or OK to merge, @Raytonne ? |
@baentsch I think it's OK to merge. Thank you! |
Thanks for the contribution, @Raytonne ! |
Update Chromium patch and build instructions:
liboqs commit:
890a6aa448598a019e72b5431d8ba8e0a5dbcc85
boringssl commit:
c0a0bb4d1243952819b983129c546f9ae1c03008
Chromium version:
124.0.6339.0