Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 March Chromium update [skip ci] #268

Merged
merged 3 commits into from
Mar 21, 2024
Merged

2024 March Chromium update [skip ci] #268

merged 3 commits into from
Mar 21, 2024

Conversation

Raytonne
Copy link
Contributor

@Raytonne Raytonne commented Mar 8, 2024

Update Chromium patch and build instructions:

liboqs commit: 890a6aa448598a019e72b5431d8ba8e0a5dbcc85
boringssl commit: c0a0bb4d1243952819b983129c546f9ae1c03008
Chromium version: 124.0.6339.0

chromium/README-Linux.md Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By splitting Linux and Windows patch base this PR seems to make maintenance harder. But as you maintain this code, @Raytonne this should be your concern. Beyond the command regarding documentation of default groups, LGTM. Thanks for upgrading this!

@Raytonne
Copy link
Contributor Author

By splitting Linux and Windows patch base this PR seems to make maintenance harder

This will make the build instruction more clear ;)

@baentsch
Copy link
Member

Thanks for the updates. Two comments: 1) Are you able to create your PR's from within the oqs-demos repo? If so, CI should be able to run automatically. If you don't have the permissions, please let me know, I'll then manually pull them over. 2) Please run your commits with option "-s": It seems the new LinuxFoundation OQS masters have activated DCO...

Raytonne and others added 3 commits March 19, 2024 12:29
Update Chromium patch and build instructions:

liboqs: 890a6aa448598a019e72b5431d8ba8e0a5dbcc85
boringssl: c0a0bb4d1243952819b983129c546f9ae1c03008
Chromium: 124.0.6339.0

Co-authored-by: pi-314159 <[email protected]>
Signed-off-by: Raytonne <[email protected]>
Signed-off-by: Raytonne <[email protected]>
Signed-off-by: Raytonne <[email protected]>
@Raytonne
Copy link
Contributor Author

Thanks for the updates. Two comments: 1) Are you able to create your PR's from within the oqs-demos repo? If so, CI should be able to run automatically. If you don't have the permissions, please let me know, I'll then manually pull them over. 2) Please run your commits with option "-s": It seems the new LinuxFoundation OQS masters have activated DCO...

  1. No. Both @Raytonne and @pi-314159 don't have permissions
  2. Done

@baentsch
Copy link
Member

Any further updates or OK to merge, @Raytonne ?

@Raytonne
Copy link
Contributor Author

@baentsch I think it's OK to merge.

Thank you!

@baentsch baentsch merged commit 374f268 into open-quantum-safe:main Mar 21, 2024
12 of 16 checks passed
@baentsch
Copy link
Member

Thanks for the contribution, @Raytonne !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants