Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PQClean commit and delete patch for HQC #2026

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

SWilson4
Copy link
Member

PQClean adopted our patch in PQClean/PQClean#578, so it is no longer necessary to apply it as part of the copy_from_upstream process. Unfortunately a lot of whitespace changes (presumably due to astyle upstream?) landed as well... I recommend using git diff --ignore-blank-lines main to review.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- also for improving the upstream!

@SWilson4 SWilson4 merged commit af78b87 into main Dec 22, 2024
80 checks passed
@SWilson4 SWilson4 deleted the sw-hqc-pqclean branch December 22, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants