Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger liboqs-java and liboqs-rust downstream CI #2021

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

SWilson4
Copy link
Member

This PR adds triggers for liboqs-java and liboqs-rust to the trigger-downstream-basic workflow.

Marked as draft pending merge of downstream PRs open-quantum-safe/liboqs-rust#271 and open-quantum-safe/liboqs-java#30.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4 SWilson4 requested a review from a team December 16, 2024 18:43
@SWilson4 SWilson4 requested a review from a team December 17, 2024 02:13
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But why is this in Draft only?

@SWilson4
Copy link
Member Author

SWilson4 commented Dec 17, 2024

LGTM. But why is this in Draft only?

Until open-quantum-safe/liboqs-rust#271 lands, the repository_dispatch API call will fail, which would break liboqs CI on main if this PR were merged.

@SWilson4 SWilson4 marked this pull request as ready for review December 17, 2024 18:17
@SWilson4 SWilson4 merged commit 416778e into main Dec 17, 2024
80 checks passed
@SWilson4 SWilson4 deleted the sw-trigger-java-rust branch December 17, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants