CPU extension detection for arm64 on NetBSD. #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joint work with Keelan Cannoo, Jeevesh Dindyal & UoM RICRG. Signed-off-by: Loganaden Velvindron <[email protected]>
Martyrshot
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Looks good to me other than some style things. @SWilson4 Do we have a NetBSD CI setup to check that this works as expected? Do we currently sanity check CPU extensions in CI?
Signed-off-by: Loganaden Velvindron <[email protected]>
Nope, no NetBSD setup. It seems like something that would be nice to have to support ongoing work on porting liboqs to NetBSD. I believe that there is also no sanity checking of CPU extensions, though it might be hidden somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joint work with Keelan Cannoo, Jeevesh Dindyal & UoM RICRG.