-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hardcode OPENSSL_ROOT_DIR to /usr on Linux #1873
Conversation
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement @SWilson4 . Conceptually LGTM. Don't understand why we did this hardcoding. As this was 4 years ago, most likely no negative impact to downstreams, but a "trigger-downstream" tag would be good, no?
Signed-off-by: Spencer Wilson <[email protected]>
It never hurts :) |
Pinging @open-quantum-safe/liboqs-committers for a second review here. |
Given that the Travis tests passed on this branch previously, and the only commit since then is the empty downstream trigger, I think it's safe to say this change will not break Travis whenever that CI system is working again (created #1888 to track). Hence I will go ahead and merge. |
Recent versions of CMake search only
OPENSSL_ROOT_DIR
if defined, so if OpenSSL is installed in a location other than/usr
(e.g.,/usr/lib/x86_64-linux-gnu
), the build will fail.Fixes #1748.