Quick fixes from Trail of Bits audit Week 1 #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
|
The most recent commit is tagged with |
bhess
approved these changes
Jul 26, 2024
baentsch
reviewed
Jul 28, 2024
| } while (0) | ||
| #else | ||
| #define OQS_OPENSSL_GUARD(x) \ |
There was a problem hiding this comment.
Is the following #define triggered if "OQS_USE_OPENSSL" is NOT set? Wouldn't seem quite right.
There was a problem hiding this comment.
Good catch. I've refactored the directives so that the guard is defined if and only if OQS_USE_OPENSSL is defined.
Signed-off-by: Spencer Wilson <[email protected]>
ashman-p
approved these changes
Jul 29, 2024
rtjk
pushed a commit
to rtjk/liboqs
that referenced
this pull request
Aug 5, 2024
* Remove unused variables from CI workflows * Add missing OpenSSL guards * Fix broken link and misplaced comment in common.c --------- Signed-off-by: Spencer Wilson <[email protected]> Signed-off-by: rtjk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1862
Fixes #1863
Fixes #1865