Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XMSS-SHAKE256_{10, 16, 20}_192 parameters #1818

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add XMSS-SHAKE256_{10, 16, 20}_192 parameters #1818

merged 1 commit into from
Jun 18, 2024

Conversation

cothan
Copy link
Contributor

@cothan cothan commented Jun 8, 2024 •
edited
Loading

Signed-off-by: Duc Tri Nguyen [email protected]

Based on the #1817. Please review #1817 first.

  • Add additional XMSS-SHAKE256{10, 16, 20}_192 parameters to meet NIST SP 800 208.
  • Add emoji to Table parameters sig_stfl_xmss.h, I hope it's helpful and save developer time.
  • Add KATs.
  • Add tests.
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@cothan cothan changed the title Add XMSS-SHAKE256_{10, 16, 20}_192 parameters #1817 Add XMSS-SHAKE256_{10, 16, 20}_192 parameters Jun 8, 2024
@cothan cothan mentioned this pull request Jun 8, 2024
Merged
2 tasks
@cothan cothan force-pushed the add_xmss-sha256_10-16-20_192_parameters branch 2 times, most recently from 5eee000 to e47e05e Compare June 17, 2024 20:04
@cothan cothan marked this pull request as ready for review June 17, 2024 23:03
@cothan cothan requested a review from dstebila as a code owner June 17, 2024 23:03
@cothan
Copy link
Contributor Author

cothan commented Jun 18, 2024

Since #1817 is merged. I will rebase this PR and merge it as well.

@cothan
add XMSS-SHAKE256_*_192 parameters
64fc2cd 
Signed-off-by: Duc Tri Nguyen <[email protected]>

make server astyle happy

update xmss.yml

update algorithm list and README

Signed-off-by: Duc Tri Nguyen <[email protected]>

clean up

Signed-off-by: Duc Tri Nguyen <[email protected]>

[trigger downstream]

Signed-off-by: Duc Tri Nguyen <[email protected]>
@cothan cothan force-pushed the add_xmss-sha256_10-16-20_192_parameters branch from adf6c3c to 64fc2cd Compare June 18, 2024 17:47
@cothan cothan merged commit e3f05cb into main Jun 18, 2024
114 checks passed
@cothan cothan deleted the add_xmss-sha256_10-16-20_192_parameters branch June 18, 2024 18:31
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWilson4 SWilson4 SWilson4 approved these changes

@ashman-p ashman-p ashman-p approved these changes

@dstebila dstebila Awaiting requested review from dstebila dstebila is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cothan @ashman-p @SWilson4