Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPHINCS+ naming in CT tests [skip ci] #1720

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

SWilson4
Copy link
Member

@SWilson4 SWilson4 commented Mar 6, 2024

Looks like the names were overwritten by mistake during the recent ML-DSA / ML-KEM additions, leading to CI failures.

Fixes #1718.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4 SWilson4 requested a review from dstebila as a code owner March 6, 2024 17:18
@SWilson4 SWilson4 added this to the 0.10.0 milestone Mar 6, 2024
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding the reason, @SWilson4 . Looking at #1626 that apparently necessitated this PR, I wonder how this could happen given we have a merge CI checking for unintended changes (e.g., to algs not impacted by a change to copy_from_upstream.yml)? Something worth while improving to avoid this may happen again?

@dstebila
Copy link
Member

dstebila commented Mar 7, 2024

Thanks for catching this!

@SWilson4 SWilson4 merged commit 565ab5c into main Mar 7, 2024
1 check passed
@SWilson4 SWilson4 deleted the sw-fix-sphincs-ct-files branch March 7, 2024 15:48
Eddy-M-K pushed a commit to Eddy-M-K/liboqs that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended generic constant-time tests failing for SPHINCS+
3 participants