Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork [skip ci] #1699

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Martyrshot
Copy link
Member

@Martyrshot Martyrshot commented Feb 17, 2024

Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork [skip ci]

This PR updates the OpenSSL link to point to oqs-provider now that OpenSSL1.1.1 is deprecated.

@Martyrshot Martyrshot requested a review from dstebila as a code owner February 17, 2024 03:29
@Martyrshot Martyrshot changed the title Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork [skip-ci] Feb 17, 2024
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wortwhile also removing the pointer to a project no longer actively maintained (openssh) and people not exactly relevant any more (Michele Mosca) pointing to PQSA and/or TSC instead?

@baentsch
Copy link
Member

(side note: use '[skip ci]' to skip CI; 'skip-ci' doesn't)

@Martyrshot
Copy link
Member Author

Ah, thanks for the tip. :-)

@Martyrshot
Copy link
Member Author

Maybe wortwhile also removing the pointer to a project no longer actively maintained (openssh) and people not exactly relevant any more (Michele Mosca) pointing to PQSA and/or TSC instead?

I think this would make a lot of sense. I would probably hold off from removing openssh until the list of projects we will continue supporting/won't continue supporting is finalized.

It wasn't clear to me how involved Michele was behind the scenes, but seeing as I started using/contributing to liboqs ~3 years ago and have never talked to them, I think it's as good a time as any haha. But there might be other reasons they is still listed, so I would defer to @dstebila on that one.

@dstebila
Copy link
Member

Maybe wortwhile also removing the pointer to a project no longer actively maintained (openssh) and people not exactly relevant any more (Michele Mosca) pointing to PQSA and/or TSC instead?

I think this would make a lot of sense. I would probably hold off from removing openssh until the list of projects we will continue supporting/won't continue supporting is finalized.

I think it's okay to remove the prominent link to OpenSSH, and I've replaced it with a link to our more general demos project.

It wasn't clear to me how involved Michele was behind the scenes, but seeing as I started using/contributing to liboqs ~3 years ago and have never talked to them, I think it's as good a time as any haha. But there might be other reasons they is still listed, so I would defer to @dstebila on that one.

This is a good time to revisit that wording, as well as also pop in wording about the Linux Foundation, which I've now done as another commit on this branch.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
…penssl1.1.1 fork [skip ci]

This PR updates the OpenSSL link to point to oqs-provider now that OpenSSL1.1.1 is deprecated.
@Martyrshot Martyrshot changed the title Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork [skip-ci] Update liboqs readme to point to oqs-provider instead of deprecated openssl1.1.1 fork [skip ci] Feb 27, 2024
@baentsch baentsch merged commit 890a6aa into main Feb 27, 2024
1 check passed
@baentsch baentsch deleted the pr1698 branch February 27, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants