Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XMSS License from (Apache 2.0 AND MIT) to (Apache 2.0 OR MIT) AND CC0-1.0 #1697

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

ducnguyen-sb
Copy link
Contributor

According to liboqs maintainer request, this PR change the license of XMSS contribution from
(Apache 2.0 AND MIT) to (Apache 2.0 OR MIT) AND CC0-1.0.

  1. Moved standalone LICENSE-MIT into LICENSE file.
  2. A few newlines, spaces format.
  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

src/sig_stfl/xmss/LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! I accept the blame for causing this work but I honestly think this is the right way to integrate the work (and honor the intentions) of the original authors. LGTM except one nit (see separate comment).

@ducnguyen-sb
Copy link
Contributor Author

@baentsch , no worry, thank you very much for reviewing the PR. Without you I couldn't catch these problems myself.

@baentsch
Copy link
Member

Without you I couldn't catch these problems myself.

Without me, you wouldn't have these problems :-) But admittedly someone else may find fault later on... Thanks again for playing ball.

@ducnguyen-sb ducnguyen-sb merged commit 5970395 into stateful-sigs Feb 13, 2024
62 of 64 checks passed
@ducnguyen-sb ducnguyen-sb deleted the stateful-sigs-xmss-license branch February 13, 2024 17:45
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
cothan pushed a commit that referenced this pull request Apr 2, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
SWilson4 pushed a commit that referenced this pull request May 14, 2024
…T) AND CC0-1.0` (#1697)

* include CC0 and convert to Apache 2.0 OR MIT

* update license

* Add missing CC0-1.0
cothan added a commit that referenced this pull request May 30, 2024
commit 244288f Add XMSS parameter xmss_sha256_h10 (#1482)
commit a7e26d9 Add 12 XMSS and 16 XMSSMT parameters. (#1489)
commit 4694fc3 Add secret key object to XMSS (#1530)
commit 99067be Add XMSS Serialize/Deserialize  (#1542)
commit 2dbfc40 Update XMSS secret key object APIs, sync with LMS  (#1588)
commit 47740ad Enforce idx from unsigned int to uint32_t. (#1611)
commit 9610576 Fix windows-x86 and arm compiling error. (#1634)
commit bb658b7 Address  stateful-sigs comments in #1650 (#1656)
commit 7db8ddf Update `sig_stfl.h` document for #1650 (#1655)
commit c3e5750 Add Apache 2.0 and MIT License to XMSS (#1662)
commit e1f02b2 Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MIT) AND CC0-1.0` (#1697)
commit 17c12c3 Add return status for XMSS lock/unlock functions. (#1712)
commit 1941636 Add return check for lock/unlock function (#1727)
commit b45415c Use `abort()` instead of exit to get the trace log. (#1728)
commit ba63672 Reduce number of `malloc/free` call in `XMSS/external` (#1724)

Signed-off-by: Duc Tri Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants