Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BIKE documentation to exclude x86 #1679

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update BIKE documentation to exclude x86 #1679

merged 2 commits into from
Jan 30, 2024

Conversation

SWilson4
Copy link
Member

We don't enable BIKE in x86 builds, and enabling it on x86 leads to CI failures. This PR is to bring documentation in line with the build configuration.

Fixes #1443.

Notably, the upstream implementation does apparently support x86, so this is something we may wish to look into.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)
    No to both.

@SWilson4
Copy link
Member Author

SWilson4 commented Jan 26, 2024

I've opened #1678 to track the inconsistency with upstream.

@SWilson4 SWilson4 merged commit 6bce010 into main Jan 30, 2024
56 checks passed
@SWilson4 SWilson4 deleted the sw-update-bike-arch branch January 30, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OQS_ENABLE_KEM_BIKE forced to OFF for ARCH_X86
3 participants