Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions to governance document #1670

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Suggestions to governance document #1670

merged 7 commits into from
Jan 22, 2024

Conversation

dstebila
Copy link
Member

No description provided.

@dstebila dstebila requested a review from baentsch January 18, 2024 21:30
@dstebila dstebila self-assigned this Jan 18, 2024
@dstebila dstebila changed the base branch from main to governance January 18, 2024 21:31
Martyrshot
Martyrshot approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Martyrshot Martyrshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some Nits.

GOVERNANCE.md Outdated Show resolved Hide resolved
baentsch
baentsch reviewed Jan 19, 2024
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
baentsch
baentsch reviewed Jan 19, 2024
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
baentsch
baentsch approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some single nits/comments.

Martyrshot
Martyrshot reviewed Jan 19, 2024
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
SWilson4
SWilson4 reviewed Jan 19, 2024
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@dstebila dstebila merged commit 99acb7b into governance Jan 22, 2024
22 of 30 checks passed
@dstebila dstebila deleted the ds-governance branch January 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWilson4 SWilson4 SWilson4 left review comments

@Martyrshot Martyrshot Martyrshot approved these changes

@baentsch baentsch baentsch approved these changes

Assignees

@dstebila dstebila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstebila @Martyrshot @SWilson4 @baentsch