-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stateful Signature (XMSS and LMS) #1650
Merged
+19,831
−202
Merged
Changes from 62 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
dad6412
Initial addition of sig_stfl API and dummy XMSS variant
cothan b0c06fa
Fix API and build issues
dstebila 7b59154
Add SIG_STFL to tests/dump_alg_info
dstebila 8e1dd5c
Update sig_stfl dummy scheme and add basic test program
dstebila 244288f
Add XMSS parameter xmss_sha256_h10 (#1482)
ducnguyen-sb c9c3835
Re-add OQS_SECRET_KEY (#1493)
dstebila e356ebf
Na lms (#1486)
ashman-p a7e26d9
Add 12 XMSS and 16 XMSSMT parameters. (#1489)
ducnguyen-sb 55094c3
LMS H5_W1 (#1513)
ashman-p 4d773d7
Convert to use OQS_SIG_STFL_SECRET_KEY struct (#1525)
ashman-p 4694fc3
Add secret key object to XMSS (#1530)
ducnguyen-sb 245aede
LMS updated to use new SK API (#1533)
ashman-p 99067be
Add XMSS Serialize/Deserialize (#1542)
ducnguyen-sb a85a9aa
Stateful sigs secret key storage callback (#1553)
ashman-p 3934949
Na statful sig lock (#1559)
ashman-p 3db6b44
Secret Key Query (#1572)
ashman-p 2446c64
Na stateful sigs lms var (#1574)
ashman-p 8df2539
Stateful sigs XMSS updates (#1590)
ashman-p 2dbfc40
Update XMSS secret key object APIs, sync with LMS (#1588)
ducnguyen-sb 47740ad
Enforce idx from unsigned int to uint32_t. (#1611)
ducnguyen-sb a7b2987
SHA2 Increment with arbitrary length (non-block sizes) (#1614)
ashman-p 2dd9e07
Na lms kat multi level (#1620)
ashman-p 982b440
Fix Build Errors (#1635)
ashman-p ddae644
Various fixes
ashman-p cc50ef0
Fix warning
ashman-p 9610576
Fix windows-x86 and arm compiling error. (#1634)
ducnguyen-sb bb658b7
Address stateful-sigs comments in #1650 (#1656)
ducnguyen-sb 7db8ddf
Update `sig_stfl.h` document for #1650 (#1655)
ducnguyen-sb cf03392
Update README.md
ashman-p 9325713
Update README.md
ashman-p a52b217
Update README.md
ashman-p d442ac9
Update README.md
ashman-p 72ab478
Update README.md
ashman-p 5967f12
Update src/CMakeLists.txt
ashman-p fc6d512
Update documentation and license text. (#1663)
ashman-p c3e5750
Add Apache 2.0 and MIT License to XMSS (#1662)
ducnguyen-sb e7a83c7
Disable Stateful Signatures in the build by default (#1676)
ashman-p 6c81bae
Na stateful macro (#1687)
ashman-p 001e96a
Update GitHub Actions workflows for stateful signatures (#1692)
SWilson4 e1f02b2
Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MI…
ducnguyen-sb 17c12c3
Add return status for XMSS lock/unlock functions. (#1712)
ducnguyen-sb 32949b7
Reformat LMS / XMSS KAT files (#1722)
SWilson4 1941636
Add return check for lock/unlock function (#1727)
ducnguyen-sb b45415c
Use `abort()` instead of exit to get the trace log. (#1728)
ducnguyen-sb ba63672
Reduce number of `malloc/free` call in `XMSS/external` (#1724)
ducnguyen-sb 8524a16
Post-rebase cleanup
SWilson4 5da49e3
Satisfy astyle
SWilson4 a535114
Fix macOS build error: lld -> llu
SWilson4 71ee535
Bring EVP_DigestUpdate calls in line with main
SWilson4 154d8e4
Fix test program linkage for cross-compiling
SWilson4 b2cdab6
Fix typo from STFL to SFTL
cothan e92aab3
Stateful sigs: Rename keygen / sign option, add more tests, fix memor…
SWilson4 b075878
Clean up OQS_SIG_STFL_SECRET_KEY_free
SWilson4 db000c2
Remove unused sig member
SWilson4 9b60f60
Naming convention for serialize / deserialize functions
SWilson4 f9a4f03
Switch order of params for deserialize
SWilson4 8c1529d
Swap param order down the stack; rename length param; update document…
SWilson4 c408cee
Update src/sig_stfl/sig_stfl.h
SWilson4 7dd4ea0
Test stateful sigs on arm64, s390x, and powerpc (#1772)
SWilson4 4ebd1b9
Update tests/example_sig_stfl.c
ashman-p 0c3d39c
Zeroing internal state memory on heap (#1790)
cothan 31bdf13
Clean up unresolved comments on stateful-sigs PR (#1793)
SWilson4 8e75f98
Update config variable name
SWilson4 ca27922
Strengthen warning in CONFIGURE.md
SWilson4 6f35f43
DCO sign-off [skip ci]
dstebila 20d39aa
I, Spencer Wilson, retroactively sign off on these commits:
SWilson4 d37f20d
I, Duc Nguyen, retroactively sign off on these commits:
cothan 3621a6b
I, Norman Ashley, retroactively sign off on these commits:
ashman-p 4fb0141
Merge branch 'main' into stateful-sigs
SWilson4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we hear suggestions to make this config option sound really dangerous and hard to accidentally enable? What about naming it "OQS_ENABLE_EXPERIMENTAL_AND_BORDERING_ON_IRRESPONSIBLE_STATEFUL_HASHBASED_SIGNATURE_AND_KEYGEN_FEATURE" (basically quoting one such feedback)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
OQS_HAZARDOUS_EXPERIMENTAL_ENABLE_SIG_STFL_KEY_SIG_GEN
as something that sounds reasonably professional while conveying the essence of "bordering on irresponsible"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.