-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riscv zephyr support #1641
Riscv zephyr support #1641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional platform support. Please also document it in "PLATFORMS.md". I'd suggest adding it as Tier 2, unless someone disagrees.
thanks for the prompt review @baentsch, added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @trigpolynom ! Now LGTM. 2nd review, please @SWilson4 @dstebila .
This is probably out of scope for this PR, but glancing at |
How would you suggest updating it? Zephyr is the only runtime where we have tests for that HW, so listing something different (Linux?) or generic might set wrong expectations. |
Ah, I meant documenting support for Zephyr on other architectures, not other OSes for RISCV. It looks to me like we have CI for Zephyr on x86 and support building Zephyr on Arm. |
Hi there, nice to see new platforms added to the Zephyr port so quickly 😄 I left a single comment regarding the general
I think this should have happened within my initial Zephyr port PR. I can add this next week once I‘m back in the office. |
Good point(s). @trigpolynom : (How) would you want to add these HW platforms to "PLATFORMS.md"? |
I'm not partial to any particular representation! I'd best defer to you and your colleagues' preferences! |
@trigpolynom as #1658 with my fixes is merged now, you can rebase to finalize this PR. 😄 |
85ff17b
to
3f1af57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update(s) @trigpolynom @Frauschi !
* Minor fixes for the `CMakeLists.txt` file in the `zephyr` directory propably happened during rebasing of #1641. * Minor improvements to the Zephyr specific CMake workarounds * RiscV distinct board references have been removed to support all RiscV boards Zephyr supports. Signed-off-by: Tobias Frauenschläger <[email protected]>
Adds riscv32 support to the zephyr-rtos module.
This addresses Issue #1416.