Support several pqclean upstream versions #1595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584.
This PR should be completed/rebased once #1589 landed.
This adds the ability to reference different pqclean versions (commits); kyber-aarch64 and dilithium-aarch64 are pinned to a new upstream name "oldpqclean". True upgrades following more current versions/commits of PQClean should be added only to the "pqclean" upstream. The logic has been tested with #1585 and seems to work OK. The proposal is to land this PR, then rebase #1585 to it.
This PR also removes the unsupported "NOT_READY" feature from
copy_from_upstream
.When this lands, an update to the documentation in the wiki is warranted/will be done.