Add XMSS secret key objects APIs, sync with LMS #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init external and parameters * fix the size of pk and sk * add cmakelist for xmss_sha256_h10 * add comment * fix format err * fix compiler warning of size_t * update to match local * add remain and total API * add sigs_remaining and sigs_total * add const to API * add kat_sig_stfl * to pass the format test * fix typo * verbose error * let's see if this work * use UINT64_MAX constant * goto err to avoid memory leaks * safe arithmetic using unsigned int and initialize lengths array * fix iteration type to match its comparison * using unsigned int instead of uint32_t to match with comparison * use memset to initialize default value * convert to unsigned int * propagate unsigned int * clean up * remove randombytes, use OQS_randombytes instead. * use calloc instead of malloc for secret_key memory initialization * remove randombytes from CMakeLists.txt * remove makefile * using namespace to separate core_hash.c * rename katfile * add test and kats for test_kat.py * add compile definition for core_hash.c * add type for t * fix typo
* Re-add OQS_SECRET_KEY * Updates per review and formating changes * Set function callback for 'free'. * Address escaped PR comment * fix formatting * Update src/sig_stfl/sig_stfl.h Co-authored-by: Douglas Stebila <[email protected]> --------- Co-authored-by: Norman Ashley <[email protected]>
* populate all 28 XMSS parameters * clean up * remove wanrings in scanbuild * change free to OQS_MEM_insecure_free * fix build warning * fix integer in i386 platforms * proper type for sigs_remain and sig_maximum * remove size_t in signature remain and total * make scan-build happy
* Support LMS H5_W1 * Fix style check * Rename CmakeLists.txt CMakeLists.txt * Add namespace * Address issues from scan results * Address SA issue * Fix formatting * Fix formatting * Commit Duc's SA fixes * Fix mem leak, and compiler warning.
* Convert API to use OQS_SIG_STFL_SECRET_KEY * Update formatting
* Initial addition of sig_stfl API and dummy XMSS variant * add secret key object * allocate and free using wrapper function instead of malloc/free * cleaner function signature * Fix comment * Delete old file * Missing newline * Missing newlines
* Use secret key struct in LMS. Update de/serialize sk API * Updates per comments * Update per comments * Fix mem leak * Address scan bild issue * Removed unused variable * Remove unused struc member * Address macOS-noopenssl build failures
* Add serialize and deserialize to XMSS --------- Co-authored-by: Norman Ashley <[email protected]>
* Callback implemention updating secret key. * Block XMSS from secret key tests until after support code has been added. * Remove / from test file names * Format * Address SA issues * Fix mem leak * Fix mem leak * Address various comments * Fix SA issue
* Add mutex protection around access to stateful secret key * Formatting. * Clean up warnings * Exclude XMSS from some tests temporarily * Remove commented code. * Document use of callback functions for secret key thread safe protection and storage.
* Added functions to query the total, as well as, the remaining numbers of signing operation for a given secret key. * Cleanup unused variable * Fix code style
* Added new LMS varients. Removed unneeded vector functions from secret key data struc. * Add LMS variants * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.