Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CMAKE_USE_PTHREADS_INIT #1576

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use CMAKE_USE_PTHREADS_INIT #1576

merged 1 commit into from
Oct 18, 2023

Conversation

zxjtan
Copy link
Contributor

@zxjtan zxjtan commented Oct 11, 2023 •
edited
Loading

Precursor to #1549. Replace OQS_USE_PTHREADS_IN_TESTS with CMAKE_USE_PTHREADS_INIT to clean up the Threads inclusion and linking story.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? NO
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? NO

@zxjtan zxjtan marked this pull request as ready for review October 11, 2023 23:00
@zxjtan zxjtan requested a review from dstebila as a code owner October 11, 2023 23:00
baentsch
baentsch approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for automating the inclusion of pthreads for testing (one less "manual" variable to think about)!

@zxjtan
Copy link
Contributor Author

zxjtan commented Oct 18, 2023

@dstebila Would you like to merge this? Or would you prefer to merge this as part of #1549 instead?

@zxjtan zxjtan mentioned this pull request Oct 18, 2023
Merged
2 tasks
@dstebila dstebila merged commit b7f35d7 into open-quantum-safe:main Oct 18, 2023
20 checks passed
@dstebila
Copy link
Member

@dstebila Would you like to merge this? Or would you prefer to merge this as part of #1549 instead?

Just merged it in now. Thanks, and sorry for the delay.

@zxjtan zxjtan mentioned this pull request Jan 5, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zxjtan @dstebila @baentsch