Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Na stateful sigs lms var #1574

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Na stateful sigs lms var #1574

merged 3 commits into from
Oct 10, 2023

Conversation

ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Oct 6, 2023

Added the rest of the LMS variants. H10, 15, 20, 25/W1, 2, 4, 8

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested a review from dstebila as a code owner October 6, 2023 16:16
@ashman-p ashman-p requested review from ducnguyen-sb, dstebila and SWilson4 and removed request for dstebila October 6, 2023 16:17
@ashman-p ashman-p self-assigned this Oct 6, 2023
SWilson4
SWilson4 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Thanks very much, Norm!

@ashman-p ashman-p merged commit 2ca5d81 into stateful-sigs Oct 10, 2023
11 checks passed
@ashman-p ashman-p deleted the na-stateful-sigs-lms-var branch October 10, 2023 16:21
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@ashman-p @SWilson4
Na stateful sigs lms var (#1574)
ab02f53 
* Added new LMS varients. Removed unneeded vector functions from secret key data struc.

* Add LMS variants

* Fix formatting
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ashman-p @SWilson4
Na stateful sigs lms var (#1574)
bd291bd 
* Added new LMS varients. Removed unneeded vector functions from secret key data struc.

* Add LMS variants

* Fix formatting
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ashman-p @cothan
Na stateful sigs lms var (#1574)
ce0b490 
* Added new LMS varients. Removed unneeded vector functions from secret key data struc.

* Add LMS variants

* Fix formatting
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ashman-p @SWilson4
Na stateful sigs lms var (#1574)
fa50f69 
* Added new LMS varients. Removed unneeded vector functions from secret key data struc.

* Add LMS variants

* Fix formatting
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ashman-p @SWilson4
Na stateful sigs lms var (#1574)
2446c64 
* Added new LMS varients. Removed unneeded vector functions from secret key data struc.

* Add LMS variants

* Fix formatting
ashman-p added a commit that referenced this pull request Jun 4, 2024
@ashman-p
I, Norman Ashley, retroactively sign off on these commits:
3621a6b 
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWilson4 SWilson4 SWilson4 approved these changes

@ducnguyen-sb ducnguyen-sb Awaiting requested review from ducnguyen-sb

@dstebila dstebila Awaiting requested review from dstebila

Assignees

@ashman-p ashman-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashman-p @SWilson4