Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Classic McEliece supression files #1568

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Update Classic McEliece supression files #1568

merged 1 commit into from
Sep 28, 2023

Conversation

praveksharma
Copy link
Member

This documents additional constant time errors reported during testing for the 0.9.0-rc1 release.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [No] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@SWilson4 SWilson4 marked this pull request as ready for review September 28, 2023 20:29
@SWilson4 SWilson4 requested a review from dstebila as a code owner September 28, 2023 20:29
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that the constant-time tests pass on this branch (run in the CI container on my machine).

@SWilson4 SWilson4 merged commit cdc8a97 into main Sep 28, 2023
39 checks passed
@dstebila dstebila deleted the ps-ct-mceliece branch November 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants