Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extensions in constant-time tests #1567

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Enable extensions in constant-time tests #1567

merged 1 commit into from
Sep 28, 2023

Conversation

SWilson4
Copy link
Member

Due to a configuration error, our weekly constant-time tests only run with OQS_OPT_TARGET=generic. This PR enables the intended configuration of OQS_OPT_TARGET=haswell by setting OQS_DIST_BUILD=OFF.

Fixes #1566.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@praveksharma praveksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SWilson4 SWilson4 merged commit a6b4e57 into main Sep 28, 2023
39 checks passed
@SWilson4 SWilson4 deleted the sw-ct-dist-build branch September 28, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant time tests only run with "generic" optimization target
2 participants