Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Na statful sig lock #1559

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Na statful sig lock #1559

merged 6 commits into from
Sep 28, 2023

Conversation

ashman-p
Copy link
Contributor

This PR enables a way to apply a lock(mutex) to secret key objects thereby giving protection from simultaneous access.
Stateful Sig API now include functions to set locking/unlocking callbacks and an associated mutex.
The library can then lock/unlock the secret key during signature generation and other queries (signing and queries for the number of signing operations remaining).

These supplied callbacks are application/OS specific.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested a review from dstebila as a code owner September 25, 2023 04:21
@ashman-p ashman-p merged commit 6334b90 into stateful-sigs Sep 28, 2023
11 checks passed
@ashman-p ashman-p deleted the na-statful-sig-lock branch September 28, 2023 17:31
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@ashman-p @SWilson4
Na statful sig lock (#1559)
a5fa645 
* Add mutex protection around access to stateful secret key

* Formatting.

* Clean up warnings

* Exclude XMSS from some tests temporarily

* Remove commented code.

* Document use of callback functions for secret key thread safe protection and storage.
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ashman-p @SWilson4
Na statful sig lock (#1559)
d687e6c 
* Add mutex protection around access to stateful secret key

* Formatting.

* Clean up warnings

* Exclude XMSS from some tests temporarily

* Remove commented code.

* Document use of callback functions for secret key thread safe protection and storage.
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ashman-p @cothan
Na statful sig lock (#1559)
e5bcfa1 
* Add mutex protection around access to stateful secret key

* Formatting.

* Clean up warnings

* Exclude XMSS from some tests temporarily

* Remove commented code.

* Document use of callback functions for secret key thread safe protection and storage.
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ashman-p @SWilson4
Na statful sig lock (#1559)
6dccf2e 
* Add mutex protection around access to stateful secret key

* Formatting.

* Clean up warnings

* Exclude XMSS from some tests temporarily

* Remove commented code.

* Document use of callback functions for secret key thread safe protection and storage.
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ashman-p @SWilson4
Na statful sig lock (#1559)
3934949 
* Add mutex protection around access to stateful secret key

* Formatting.

* Clean up warnings

* Exclude XMSS from some tests temporarily

* Remove commented code.

* Document use of callback functions for secret key thread safe protection and storage.
ashman-p added a commit that referenced this pull request Jun 4, 2024
@ashman-p
I, Norman Ashley, retroactively sign off on these commits:
3621a6b 
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila Awaiting requested review from dstebila

@SWilson4 SWilson4 Awaiting requested review from SWilson4

@ducnguyen-sb ducnguyen-sb Awaiting requested review from ducnguyen-sb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ashman-p