Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Align VS test folder with all other Generators #1557

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

res0nance
Copy link
Contributor

This aligns the output folder for tests much like other platforms.

Fixes #1555

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

tests/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach (better): It's good that VS differentiates binaries between build types, but as ninja doesn't, this PR creates identical behaviour also eliminating the github env var dependency in the previous solution. It's certainly easier than replicating the VS behaviour in ninja builds...

This aligns the output folder for tests much like other
platforms.
@baentsch baentsch merged commit 352cd05 into open-quantum-safe:main Sep 22, 2023
20 checks passed
@baentsch
Copy link
Member

Merged: Thanks for the contribution!

@res0nance res0nance deleted the vs-test-output branch September 7, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail: cannot find test program files on Windows in the build tree with a VS generator
2 participants