-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyber/Dilithium fips versions -> standard branch #1543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask for a change to the version ID of the algs, please? Otherwise https://github.com/open-quantum-safe/oqs-provider/blob/main/oqs-template/oqs-sig-info.md for example will show the same algorithm "Implementation Version" for a different OID: Would be IMO pretty confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM now.
Thanks again for PR and updates -- I'd suggest to wait with merge until Sep 13 to see whether we really have to go this route (or a straight merge as per #1537 (comment) is preferred (@dstebila @cryptojedi ?) and we can avoid maintaining separate branches). If we need to do it, I'll then set up a separate branch in |
PR to merge the Kyber/Dilithium (fips draft versions) to a standard branch. May be obsolete once #1537 is resolved.