Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyber/Dilithium fips versions -> standard branch #1543

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

bhess
Copy link
Member

@bhess bhess commented Sep 8, 2023

PR to merge the Kyber/Dilithium (fips draft versions) to a standard branch. May be obsolete once #1537 is resolved.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask for a change to the version ID of the algs, please? Otherwise https://github.com/open-quantum-safe/oqs-provider/blob/main/oqs-template/oqs-sig-info.md for example will show the same algorithm "Implementation Version" for a different OID: Would be IMO pretty confusing.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now.

@baentsch
Copy link
Member

baentsch commented Sep 9, 2023

Thanks again for PR and updates -- I'd suggest to wait with merge until Sep 13 to see whether we really have to go this route (or a straight merge as per #1537 (comment) is preferred (@dstebila @cryptojedi ?) and we can avoid maintaining separate branches). If we need to do it, I'll then set up a separate branch in oqsprovider with the new OIDs you provided to BouncyCastle so you don't have to bother with that too.

@baentsch baentsch merged commit 3cca419 into standard Sep 21, 2023
15 checks passed
@dstebila dstebila deleted the bhe-fips204 branch December 14, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants