Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Classic McEliece supression files #1527

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update Classic McEliece supression files #1527

merged 2 commits into from
Aug 15, 2023

Conversation

praveksharma
Copy link
Member

The constant time behaviour for Classic McEliece changed after #1470 merged. This PR updates the Valgrind suppression files for the constant time tests.

It is worth noting that the failures that Valgrind reports depend on the environment I'm running the constant time tests in. Valgrind reports additional errors when running on my machine's native build environment as opposed to the ci-ubuntu-focal-x86_64 docker image; this PR documents those additional errors.

All errors are documented as "issues" at the moment. A later review by a McEcliece expert to sort these errors into "issues" and "passes" would be beneficial .

This fixes #1515.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [No] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@praveksharma praveksharma requested a review from dstebila as a code owner August 14, 2023 14:13
@SWilson4 SWilson4 added this to the 0.9.0 milestone Aug 14, 2023
@praveksharma praveksharma merged commit 348ab36 into main Aug 15, 2023
@dstebila dstebila deleted the ps-mceliece-ct branch August 18, 2023 14:22
@bhess
Copy link
Member

bhess commented Aug 31, 2023

While updating the dilithium suppression files for #1537, I noticed that there are still some ct-errors with McEliece, see the log attached:
test_constant_time.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekly constant time tests failing on McEliece
4 participants