Update Classic McEliece supression files #1527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant time behaviour for Classic McEliece changed after #1470 merged. This PR updates the Valgrind suppression files for the constant time tests.
It is worth noting that the failures that Valgrind reports depend on the environment I'm running the constant time tests in. Valgrind reports additional errors when running on my machine's native build environment as opposed to the
ci-ubuntu-focal-x86_64
docker image; this PR documents those additional errors.All errors are documented as "issues" at the moment. A later review by a McEcliece expert to sort these errors into "issues" and "passes" would be beneficial .
This fixes #1515.