Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of Cisco's open source LMS #1430

Closed
wants to merge 13 commits into from
Closed

Conversation

ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Apr 6, 2023

This is the initial commit. The following commits should have more weighty code additions.

Fixes #1098.

  • [N] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [Y] Does this PR change the the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the initial commit. The following commits should have more weighty code additions.

I'm not sure I like this approach: Are you saying you want to keep adding to a PR during development? This will generate loads of unnecessary notification emails to the whole team (which in turn will lead to all emails about your work to be disregarded); it further isn't particularly helpful (e.g., for auto-filtering out those emails) that this PR is not marked Draft.

My preference would be for a PR to be created in OQS only when it's basically done -- and to be marked Ready for Review only when its CI passes.

@ashman-p ashman-p marked this pull request as draft April 6, 2023 05:07
@ashman-p ashman-p self-assigned this Apr 6, 2023
@ashman-p
Copy link
Contributor Author

ashman-p commented Apr 6, 2023

No worries, i get it. I most likely misunderstood the discussion concerning the initial commit of the LMS source and preferences on code sizes for reviews.

@xvzcf
Copy link
Contributor

xvzcf commented Apr 11, 2023

My preference would be for a PR to be created in OQS only when it's basically done -- and to be marked Ready for Review only when its CI passes.

Rather than having a single big PR, I think we should break this into several PRs such that each is a unit of work that can be merged in. We could discuss this further in the status meeting.

@xvzcf xvzcf deleted the branch xmss-test May 1, 2023 16:08
@xvzcf xvzcf closed this May 1, 2023
@ashman-p ashman-p deleted the xmss-lms-test branch February 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants