-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of Cisco's open source LMS #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the initial commit. The following commits should have more weighty code additions.
I'm not sure I like this approach: Are you saying you want to keep adding to a PR during development? This will generate loads of unnecessary notification emails to the whole team (which in turn will lead to all emails about your work to be disregarded); it further isn't particularly helpful (e.g., for auto-filtering out those emails) that this PR is not marked Draft.
My preference would be for a PR to be created in OQS only when it's basically done -- and to be marked Ready for Review only when its CI passes.
No worries, i get it. I most likely misunderstood the discussion concerning the initial commit of the LMS source and preferences on code sizes for reviews. |
Rather than having a single big PR, I think we should break this into several PRs such that each is a unit of work that can be merged in. We could discuss this further in the status meeting. |
This is the initial commit. The following commits should have more weighty code additions.
Fixes #1098.